Mirrors/bx
1
0
Fork 0
mirror of https://github.com/bkaradzic/bx.git synced 2026-02-18 04:53:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixed bx::writeRep infinite loop on error.

Browse Source
This commit is contained in:
Бранимир Караџић
2024-04-19 10:22:28 -07:00
parent d343470738
commit e615943f98
2 changed files with 25 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/bx/inline/readerwriter.inl
View File

@@ -308,7 +308,7 @@ namespace bx
memSet(temp, _byte, blockSize);
int32_t size = 0;
while (0 < _size)
while (0 < _size && _err->isOk() )
{
int32_t bytes = write(_writer, temp, uint32_min(blockSize, _size), _err);
size += bytes;

24
tests/readerwriter_test.cpp
View File

@@ -29,3 +29,27 @@ TEST_CASE("writeBE", "")
REQUIRE(err.isOk() );
REQUIRE(total == 4);
}
TEST_CASE("writeRep", "")
{
uint8_t tmp[1389];
bx::StaticMemoryBlock mb(tmp, sizeof(tmp) );
bx::MemoryWriter writer(&mb);
bx::Error err;
int32_t total = 0;
total += bx::writeRep(&writer, 0xfb, BX_COUNTOF(tmp)-1, &err);
REQUIRE(err.isOk() );
REQUIRE(BX_COUNTOF(tmp)-1 == total);
total += bx::writeRep(&writer, 0xfb, 2, &err);
REQUIRE(!err.isOk() );
REQUIRE(BX_COUNTOF(tmp) == total);
for (uint32_t ii = 0; ii < BX_COUNTOF(tmp); ++ii)
{
REQUIRE(0xfb == tmp[ii]);
}
}