Mirrors/bx
1
0
Fork 0
mirror of https://github.com/bkaradzic/bx.git synced 2026-02-17 20:52:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

vsnprintf: Fix crash when _out is NULL.

Browse Source
This commit is contained in:
Бранимир Караџић
2024-12-04 19:23:10 -08:00
parent 4a1f0ab630
commit 32e578b22f
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/string.cpp
View File

@@ -1230,7 +1230,8 @@ namespace bx
int32_t vsnprintf(char* _out, int32_t _max, const char* _format, va_list _argList)
{
if (0 < _max)
if ( 0 < _max
&& NULL != _out)
{
StaticMemoryBlockWriter writer(_out, uint32_t(_max) );

8
tests/vsnprintf_test.cpp
View File

@@ -30,6 +30,14 @@ TEST_CASE("Truncated output buffer.", "[string][printf]")
REQUIRE(4 == bx::snprintf(buffer1, BX_COUNTOF(buffer1), "abvg") );
REQUIRE('\0' == buffer1[BX_COUNTOF(buffer1)-1]);
buffer1[0] = '\xfb'; // null destination
REQUIRE(4 == bx::snprintf(NULL, BX_COUNTOF(buffer1), "abvg") );
REQUIRE('\xfb' == buffer1[0]);
buffer1[0] = '\xbf'; // one byte destination
REQUIRE(4 == bx::snprintf(buffer1, 1, "abvg") );
REQUIRE('\0' == buffer1[0]);
char buffer7[7]; // truncate
REQUIRE(10 == bx::snprintf(NULL, 0, "Ten chars!") );
REQUIRE(10 == bx::snprintf(buffer7, BX_COUNTOF(buffer7), "Ten chars!") );