Mirrors/bgfx
1
0
Fork 0
mirror of https://github.com/bkaradzic/bgfx.git synced 2026-02-17 20:52:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use bx::bit_cast where appropriate for type punning, applying packed struct for arrays when necessary (#3212)

Browse Source
This commit is contained in:
pheonix
2024-02-24 15:47:04 -08:00
committed by GitHub
parent c75b9cb57d
commit 0b049d4897
4 changed files with 12 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
examples/09-hdr/hdr.cpp
View File

@@ -362,9 +362,10 @@ public:
if (bgfx::isValid(m_rb) )
{
union { uint32_t color; uint8_t bgra[4]; } cast = { m_lumBgra8 };
float exponent = cast.bgra[3]/255.0f * 255.0f - 128.0f;
float lumAvg = cast.bgra[2]/255.0f * bx::exp2(exponent);
struct Packed { uint8_t bgra[4]; } arr = bx::bit_cast<Packed>(m_lumBgra8);
float exponent = arr.bgra[3] / 255.0f * 255.0f - 128.0f;
float lumAvg = arr.bgra[2] / 255.0f * bx::exp2(exponent);
ImGui::SliderFloat("Lum Avg", &lumAvg, 0.0f, 1.0f);
}

28
examples/33-pom/pom.cpp
View File

@@ -37,29 +37,15 @@ struct PosTangentBitangentTexcoordVertex
bgfx::VertexLayout PosTangentBitangentTexcoordVertex::ms_layout;
uint32_t packUint32(uint8_t _x, uint8_t _y, uint8_t _z, uint8_t _w)
{
union
{
uint32_t ui32;
uint8_t arr[4];
} un;
un.arr[0] = _x;
un.arr[1] = _y;
un.arr[2] = _z;
un.arr[3] = _w;
return un.ui32;
}
uint32_t packF4u(float _x, float _y = 0.0f, float _z = 0.0f, float _w = 0.0f)
{
const uint8_t xx = uint8_t(_x*127.0f + 128.0f);
const uint8_t yy = uint8_t(_y*127.0f + 128.0f);
const uint8_t zz = uint8_t(_z*127.0f + 128.0f);
const uint8_t ww = uint8_t(_w*127.0f + 128.0f);
return packUint32(xx, yy, zz, ww);
struct Packed { uint8_t value[4]; } arr = { 0 };
arr.value[0] = uint8_t(_x * 127.0f + 128.0f);
arr.value[1] = uint8_t(_y * 127.0f + 128.0f);
arr.value[2] = uint8_t(_z * 127.0f + 128.0f);
arr.value[3] = uint8_t(_w * 127.0f + 128.0f);
return bx::bit_cast<uint32_t>(arr);
}
static PosTangentBitangentTexcoordVertex s_cubeVertices[24] =

7
src/bgfx_p.h
View File

@@ -605,13 +605,6 @@ namespace bgfx
release( (const Memory*)_mem);
}
inline uint32_t castfu(float _value)
{
union { float fl; uint32_t ui; } un;
un.fl = _value;
return un.ui;
}
inline uint64_t packStencil(uint32_t _fstencil, uint32_t _bstencil)
{
return (uint64_t(_bstencil)<<32)|uint64_t(_fstencil);

3
src/shader_dxbc.cpp
View File

@@ -1723,11 +1723,10 @@ namespace bgfx
case DxbcOperandType::Imm64:
for (uint32_t jj = 0; jj < operand.num; ++jj)
{
union { uint32_t i; float f; } cast = { operand.un.imm32[jj] };
size += bx::snprintf(&_out[size], bx::uint32_imax(0, _size-size)
, "%s%f"
, 0 == jj ? "(" : ", "
, cast.f
, bx::bit_cast<float>(operand.un.imm32[jj])
);
}