From fa82fe8e6788e57553371d58fa783df01c32717f Mon Sep 17 00:00:00 2001 From: nossr50 Date: Thu, 9 Jun 2022 22:50:36 -0700 Subject: [PATCH] Level up broadcasts should be visible to the player of origin --- Changelog.txt | 1 + .../com/gmail/nossr50/datatypes/LevelUpBroadcastPredicate.java | 2 +- .../gmail/nossr50/datatypes/PowerLevelUpBroadcastPredicate.java | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Changelog.txt b/Changelog.txt index 1227eb850..098c849e4 100644 --- a/Changelog.txt +++ b/Changelog.txt @@ -1,5 +1,6 @@ Version 2.1.214 Temporarily removed FakePlayerAnimationEvent (see notes) + Players can now see their own level up broadcasts NOTES: Spigot updated PlayerAnimationEvent with an API break between versions 1.18 and 1.19, as a temporary fix for mcMMO to be able to support both of these diff --git a/src/main/java/com/gmail/nossr50/datatypes/LevelUpBroadcastPredicate.java b/src/main/java/com/gmail/nossr50/datatypes/LevelUpBroadcastPredicate.java index 1644fdd1b..f19ec041e 100644 --- a/src/main/java/com/gmail/nossr50/datatypes/LevelUpBroadcastPredicate.java +++ b/src/main/java/com/gmail/nossr50/datatypes/LevelUpBroadcastPredicate.java @@ -74,7 +74,7 @@ public class LevelUpBroadcastPredicate implements Predi } //Visibility checks - if(!listeningPlayer.canSee(mmoBroadcastingPlayer.getPlayer())) { + if(!listeningPlayer.canSee(mmoBroadcastingPlayer.getPlayer()) && listeningPlayer != mmoBroadcastingPlayer.getPlayer()) { return false; //Player who leveled should be invisible to this player so don't send the message } diff --git a/src/main/java/com/gmail/nossr50/datatypes/PowerLevelUpBroadcastPredicate.java b/src/main/java/com/gmail/nossr50/datatypes/PowerLevelUpBroadcastPredicate.java index 17bc2fd04..05e7a3a1a 100644 --- a/src/main/java/com/gmail/nossr50/datatypes/PowerLevelUpBroadcastPredicate.java +++ b/src/main/java/com/gmail/nossr50/datatypes/PowerLevelUpBroadcastPredicate.java @@ -74,7 +74,7 @@ public class PowerLevelUpBroadcastPredicate implements } //Visibility checks - if(!listeningPlayer.canSee(mmoBroadcastingPlayer.getPlayer())) { + if(!listeningPlayer.canSee(mmoBroadcastingPlayer.getPlayer()) && listeningPlayer != mmoBroadcastingPlayer.getPlayer()) { return false; //Player who leveled should be invisible to this player so don't send the message }