diff --git a/Changelog.txt b/Changelog.txt index 3fdfb29e8..1beb1f36e 100644 --- a/Changelog.txt +++ b/Changelog.txt @@ -1,3 +1,7 @@ +Version 2.1.226 + Added Short_Grass to experience.yml for Herbalism + Updated Hylian Treasures "Bushes" alias to use short_grass when playing on new Minecraft versions + Fixed dirt_path and grass_block not being correctly whitelisted as Version 2.1.225 Fixed text from mcMMO not being sent or displayed to the player Updated Adventure dependencies diff --git a/pom.xml b/pom.xml index db44cc976..774ee3a55 100644 --- a/pom.xml +++ b/pom.xml @@ -2,7 +2,7 @@ 4.0.0 com.gmail.nossr50.mcMMO mcMMO - 2.1.226-SNAPSHOT + 2.1.226 mcMMO https://github.com/mcMMO-Dev/mcMMO @@ -342,7 +342,7 @@ org.spigotmc spigot-api - 1.20.1-R0.1-SNAPSHOT + 1.20.4-R0.1-SNAPSHOT provided diff --git a/src/main/java/com/gmail/nossr50/commands/McImportCommand.java b/src/main/java/com/gmail/nossr50/commands/McImportCommand.java index ce43f9675..3c913ea47 100644 --- a/src/main/java/com/gmail/nossr50/commands/McImportCommand.java +++ b/src/main/java/com/gmail/nossr50/commands/McImportCommand.java @@ -204,7 +204,7 @@ public class McImportCommand implements CommandExecutor { else if (materialName.contains("LOG") || materialName.contains("LEAVES")) { skillName = "Woodcutting"; } - else if (materialName.contains("GRASS") || materialName.contains("FLOWER") || materialName.contains("CROP")) { + else if (materialName.contains("GRASS") || materialName.contains("SHORT_GRASS") || materialName.contains("FLOWER") || materialName.contains("CROP")) { skillName = "Herbalism"; } else if (materialName.contains("DIRT") || materialName.contains("SAND")) { diff --git a/src/main/java/com/gmail/nossr50/config/treasure/TreasureConfig.java b/src/main/java/com/gmail/nossr50/config/treasure/TreasureConfig.java index 456ab4531..97967a131 100755 --- a/src/main/java/com/gmail/nossr50/config/treasure/TreasureConfig.java +++ b/src/main/java/com/gmail/nossr50/config/treasure/TreasureConfig.java @@ -4,6 +4,7 @@ import com.gmail.nossr50.config.BukkitConfig; import com.gmail.nossr50.datatypes.treasure.ExcavationTreasure; import com.gmail.nossr50.datatypes.treasure.HylianTreasure; import com.gmail.nossr50.mcMMO; +import com.gmail.nossr50.util.BlockUtils; import com.gmail.nossr50.util.LogUtils; import com.gmail.nossr50.util.text.StringUtils; import org.bukkit.ChatColor; @@ -228,7 +229,7 @@ public class TreasureConfig extends BukkitConfig { for (String dropper : dropList) { if (dropper.equals("Bushes")) { AddHylianTreasure(StringUtils.getFriendlyConfigMaterialString(Material.FERN), hylianTreasure); - AddHylianTreasure(StringUtils.getFriendlyConfigMaterialString(Material.TALL_GRASS), hylianTreasure); + AddHylianTreasure(StringUtils.getFriendlyConfigMaterialString(BlockUtils.getShortGrass()), hylianTreasure); for (Material species : Tag.SAPLINGS.getValues()) AddHylianTreasure(StringUtils.getFriendlyConfigMaterialString(species), hylianTreasure); diff --git a/src/main/java/com/gmail/nossr50/util/BlockUtils.java b/src/main/java/com/gmail/nossr50/util/BlockUtils.java index d9df151f6..7ef3cbc81 100644 --- a/src/main/java/com/gmail/nossr50/util/BlockUtils.java +++ b/src/main/java/com/gmail/nossr50/util/BlockUtils.java @@ -22,6 +22,9 @@ import java.util.HashSet; public final class BlockUtils { + public static final String SHORT_GRASS = "SHORT_GRASS"; + public static final String GRASS = "GRASS"; + private BlockUtils() { } @@ -38,6 +41,21 @@ public final class BlockUtils { blockState.setMetadata(MetadataConstants.METADATA_KEY_BONUS_DROPS, new BonusDropMeta(1, mcMMO.p)); } + /** + * Util method for compatibility across Minecraft versions, grabs the {@link Material} enum for short_grass + * + * @return the {@link Material} enum for short_grass + */ + public static Material getShortGrass() { + if (Material.getMaterial(SHORT_GRASS) != null) { + return Material.getMaterial(SHORT_GRASS); + } else if (Material.getMaterial(GRASS) != null) { + return Material.getMaterial(GRASS); + } else { + throw new UnsupportedOperationException("Unable to find short grass material"); + } + } + /** * Set up the state for a block to be seen as unnatural and cleanup any unwanted metadata from the block * @param block target block diff --git a/src/main/java/com/gmail/nossr50/util/MaterialMapStore.java b/src/main/java/com/gmail/nossr50/util/MaterialMapStore.java index 16b5a73e4..6a54cd608 100644 --- a/src/main/java/com/gmail/nossr50/util/MaterialMapStore.java +++ b/src/main/java/com/gmail/nossr50/util/MaterialMapStore.java @@ -996,8 +996,8 @@ public class MaterialMapStore { private void fillShroomyWhiteList() { canMakeShroomyWhiteList.add("dirt"); - canMakeShroomyWhiteList.add("grass"); - canMakeShroomyWhiteList.add("grass_path"); + canMakeShroomyWhiteList.add("grass_block"); + canMakeShroomyWhiteList.add("dirt_path"); } private void fillBlockCrackerWhiteList() @@ -1010,8 +1010,8 @@ public class MaterialMapStore { private void fillHerbalismAbilityBlackList() { herbalismAbilityBlackList.add("dirt"); - herbalismAbilityBlackList.add("grass"); - herbalismAbilityBlackList.add("grass_path"); + herbalismAbilityBlackList.add("grass_block"); + herbalismAbilityBlackList.add("dirt_path"); herbalismAbilityBlackList.add("farmland"); } diff --git a/src/main/resources/experience.yml b/src/main/resources/experience.yml index 7c4111c59..00e72f01d 100644 --- a/src/main/resources/experience.yml +++ b/src/main/resources/experience.yml @@ -393,6 +393,7 @@ Experience_Values: Rose_Bush: 50 Fern: 10 Grass: 10 + Short_Grass: 10 Sugar_Cane: 30 Sunflower: 50 Tall_Grass: 50