From 8708c9feba147e734ac769e809d68961e8e7f40b Mon Sep 17 00:00:00 2001 From: Sandy Date: Fri, 14 Jun 2024 23:23:09 -0400 Subject: [PATCH] Don't suggest `/Zc:__cplusplus` for clang compiler on windows (#328) This fixes an error when using the clang compiler on windows using `-std=c++23` (llvm 18). The error message is not meant for clang and `/Zc:__cplusplus` is invalid for clang as the compiler properly sets `__cplusplus`. --- include/bx/platform.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/bx/platform.h b/include/bx/platform.h index ff5ee00..66f15f9 100644 --- a/include/bx/platform.h +++ b/include/bx/platform.h @@ -453,9 +453,9 @@ #endif // BX_ARCH_ #if defined(__cplusplus) -# if defined(_MSVC_LANG) && _MSVC_LANG != __cplusplus +# if BX_COMPILER_MSVC && defined(_MSVC_LANG) && _MSVC_LANG != __cplusplus # error "When using MSVC you must set /Zc:__cplusplus compiler option." -# endif // defined(_MSVC_LANG) && _MSVC_LANG != __cplusplus +# endif // BX_COMPILER_MSVC && defined(_MSVC_LANG) && _MSVC_LANG != __cplusplus # if __cplusplus < BX_LANGUAGE_CPP17 # error "C++17 standard support is required to build."