From 3a67e19e99af348c71ff126c1c6dc61516a4061c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Branimir=20Karad=C5=BEi=C4=87?= Date: Sun, 25 Nov 2018 20:10:24 -0800 Subject: [PATCH] Cleanup. --- include/bx/commandline.h | 3 +-- include/bx/easing.h | 4 ---- include/bx/inline/bx.inl | 5 +++-- include/bx/inline/easing.inl | 4 ++++ include/bx/inline/math.inl | 15 +++++++++++---- include/bx/inline/pixelformat.inl | 5 +++-- include/bx/math.h | 4 ---- src/commandline.cpp | 2 +- src/filepath.cpp | 5 +++-- 9 files changed, 26 insertions(+), 21 deletions(-) diff --git a/include/bx/commandline.h b/include/bx/commandline.h index f1f1af0..dbd2af3 100644 --- a/include/bx/commandline.h +++ b/include/bx/commandline.h @@ -10,8 +10,7 @@ namespace bx { - /// Reference: - /// http://msdn.microsoft.com/en-us/library/a1y7w461.aspx + /// StringView tokenizeCommandLine(const StringView& _commandLine, char* _buffer, uint32_t& _bufferSize, int32_t& _argc, char* _argv[], int32_t _maxArgvs, char _term = '\0'); /// diff --git a/include/bx/easing.h b/include/bx/easing.h index a59f39a..8581b97 100644 --- a/include/bx/easing.h +++ b/include/bx/easing.h @@ -8,10 +8,6 @@ #include "math.h" -// Reference: -// http://easings.net/ -// http://robertpenner.com/easing/ - namespace bx { /// diff --git a/include/bx/inline/bx.inl b/include/bx/inline/bx.inl index 34c8948..c17649a 100644 --- a/include/bx/inline/bx.inl +++ b/include/bx/inline/bx.inl @@ -9,8 +9,9 @@ namespace bx { - // Reference: - // https://web.archive.org/web/20181115035420/http://cnicholson.net/2011/01/stupid-c-tricks-a-better-sizeof_array/ + // Reference(S): + // - https://web.archive.org/web/20181115035420/http://cnicholson.net/2011/01/stupid-c-tricks-a-better-sizeof_array/ + // template char(&CountOfRequireArrayArgumentT(const Ty(&)[Num]))[Num]; diff --git a/include/bx/inline/easing.inl b/include/bx/inline/easing.inl index 12c237d..3cdab9a 100644 --- a/include/bx/inline/easing.inl +++ b/include/bx/inline/easing.inl @@ -7,6 +7,10 @@ # error "Must be included from bx/easing.h!" #endif // BX_EASING_H_HEADER_GUARD + // Reference(s): + // - https://web.archive.org/web/20181126040153/https://easings.net/ + // - https://web.archive.org/web/20181126040212/http://robertpenner.com/easing/ + // namespace bx { template diff --git a/include/bx/inline/math.inl b/include/bx/inline/math.inl index 060b8bb..de63e4e 100644 --- a/include/bx/inline/math.inl +++ b/include/bx/inline/math.inl @@ -49,8 +49,9 @@ namespace bx inline BX_CONST_FUNC uint32_t floatFlip(uint32_t _value) { - // Reference: - // http://archive.fo/2012.12.08-212402/http://stereopsis.com/radix.html + // Reference(s): + // - http://archive.fo/2012.12.08-212402/http://stereopsis.com/radix.html + // const uint32_t tmp0 = uint32_sra(_value, 31); const uint32_t tmp1 = uint32_neg(tmp0); const uint32_t mask = uint32_or(tmp1, 0x80000000); @@ -259,8 +260,9 @@ namespace bx inline constexpr BX_CONST_FUNC bool equal(float _a, float _b, float _epsilon) { - // Reference: - // https://web.archive.org/web/20181103180318/http://realtimecollisiondetection.net/blog/?p=89 + // Reference(s): + // - https://web.archive.org/web/20181103180318/http://realtimecollisiondetection.net/blog/?p=89 + // const float lhs = abs(_a - _b); const float rhs = _epsilon * max(1.0f, abs(_a), abs(_b) ); return lhs <= rhs; @@ -305,6 +307,11 @@ namespace bx inline constexpr BX_CONST_FUNC float gain(float _time, float _gain) { + // Reference(s): + // - Bias And Gain Are Your Friend + // https://web.archive.org/web/20181126040535/https://blog.demofox.org/2012/09/24/bias-and-gain-are-your-friend/ + // https://web.archive.org/web/20181126040558/http://demofox.org/biasgain.html + // if (_time < 0.5f) { return bias(_time * 2.0f, _gain) * 0.5f; diff --git a/include/bx/inline/pixelformat.inl b/include/bx/inline/pixelformat.inl index 9bc6109..8ac0281 100644 --- a/include/bx/inline/pixelformat.inl +++ b/include/bx/inline/pixelformat.inl @@ -707,8 +707,9 @@ namespace bx template inline void encodeRgbE(float* _dst, const float* _src) { - // Reference: - // https://www.opengl.org/registry/specs/EXT/texture_shared_exponent.txt + // Reference(s): + // - https://web.archive.org/web/20181126040035/https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_texture_shared_exponent.txt + // const int32_t expMax = (1<