Mirrors/bgfx
1
0
Fork 0
mirror of https://github.com/bkaradzic/bgfx.git synced 2026-02-20 13:53:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixed some false positive clang analysis warnings.

Browse Source
This commit is contained in:
Branimir Karadžić
2014-10-21 23:38:16 -07:00
parent 237ee5b9e5
commit 41fae47351
2 changed files with 33 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
src/bgfx.cpp
View File

@@ -578,6 +578,10 @@ namespace bgfx
fragMem[ii] = makeRef(mem[ii].data, uint32_t(mem[ii].size) );
}
}
else
{
BGFX_FATAL(false, Fatal::UnableToInitialize, "Unknown renderer type %d", g_caps.rendererType);
}
for (uint32_t ii = 0, num = g_caps.maxFBAttachments; ii < num; ++ii)
{
@@ -1419,6 +1423,25 @@ again:
bool end = false;
if (NULL == m_renderCtx)
{
uint8_t command;
_cmdbuf.read(command);
BX_CHECK(CommandBuffer::RendererInit == command
, "RendererInit must be the first command in command buffer before initialization."
);
BX_CHECK(!m_rendererInitialized, "This shouldn't happen! Bad synchronization?");
RendererType::Enum type;
_cmdbuf.read(type);
m_renderCtx = rendererCreate(type);
m_rendererInitialized = true;
}
BX_CHECK(NULL != m_renderCtx, "Should not be NULL at this point.");
do
{
uint8_t command;
@@ -1426,18 +1449,6 @@ again:
switch (command)
{
case CommandBuffer::RendererInit:
{
BX_CHECK(!m_rendererInitialized, "This shouldn't happen! Bad synchronization?");
RendererType::Enum type;
_cmdbuf.read(type);
m_renderCtx = rendererCreate(type);
m_rendererInitialized = true;
}
break;
case CommandBuffer::RendererShutdownBegin:
{
BX_CHECK(m_rendererInitialized, "This shouldn't happen! Bad synchronization?");
@@ -1452,6 +1463,10 @@ again:
m_renderCtx = NULL;
m_exit = true;
}
// fallthrough
case CommandBuffer::End:
end = true;
break;
case CommandBuffer::CreateIndexBuffer:
@@ -1834,10 +1849,6 @@ again:
}
break;
case CommandBuffer::End:
end = true;
break;
default:
BX_CHECK(false, "Invalid command: %d", command);
break;