From 14dccb7f1ebc0eac5553de2a24bd3bdfb3a96084 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Branimir=20Karad=C5=BEi=C4=87?= Date: Thu, 19 Jan 2017 00:22:06 -0800 Subject: [PATCH] Cleanup. --- examples/common/bgfx_utils.cpp | 1 + src/image.cpp | 2 +- tools/shaderc/shaderc.cpp | 18 +++++++++--------- tools/texturec/texturec.cpp | 1 + tools/texturev/texturev.cpp | 2 +- 5 files changed, 13 insertions(+), 11 deletions(-) diff --git a/examples/common/bgfx_utils.cpp b/examples/common/bgfx_utils.cpp index 7955ed3aa..f728582cc 100644 --- a/examples/common/bgfx_utils.cpp +++ b/examples/common/bgfx_utils.cpp @@ -23,6 +23,7 @@ namespace stl = tinystl; BX_PRAGMA_DIAGNOSTIC_PUSH() BX_PRAGMA_DIAGNOSTIC_IGNORED_CLANG_GCC("-Wtype-limits") +BX_PRAGMA_DIAGNOSTIC_IGNORED_CLANG_GCC("-Wunused-parameter") BX_PRAGMA_DIAGNOSTIC_IGNORED_CLANG_GCC("-Wunused-value") BX_PRAGMA_DIAGNOSTIC_IGNORED_MSVC(4100) // error C4100: '' : unreferenced formal parameter #define MINIZ_NO_STDIO diff --git a/src/image.cpp b/src/image.cpp index 3b9169a23..5ac9b80e9 100644 --- a/src/image.cpp +++ b/src/image.cpp @@ -235,7 +235,7 @@ namespace bgfx const TextureFormat::Enum fmt = TextureFormat::Enum(ii); if (isValid(fmt) ) { - if (0 == bx::stricmp(s_textureFormatName[ii], _name) ) + if (0 == bx::strincmp(s_textureFormatName[ii], _name) ) { return fmt; } diff --git a/tools/shaderc/shaderc.cpp b/tools/shaderc/shaderc.cpp index 517cf13a0..d6fb548fc 100644 --- a/tools/shaderc/shaderc.cpp +++ b/tools/shaderc/shaderc.cpp @@ -927,22 +927,22 @@ namespace bgfx , essl ? 1 : glsl ); - if (0 == bx::stricmp(platform, "android") ) + if (0 == bx::strincmp(platform, "android") ) { preprocessor.setDefine("BX_PLATFORM_ANDROID=1"); preprocessor.setDefine("BGFX_SHADER_LANGUAGE_GLSL=1"); } - else if (0 == bx::stricmp(platform, "asm.js") ) + else if (0 == bx::strincmp(platform, "asm.js") ) { preprocessor.setDefine("BX_PLATFORM_EMSCRIPTEN=1"); preprocessor.setDefine("BGFX_SHADER_LANGUAGE_GLSL=1"); } - else if (0 == bx::stricmp(platform, "ios") ) + else if (0 == bx::strincmp(platform, "ios") ) { preprocessor.setDefine("BX_PLATFORM_IOS=1"); preprocessor.setDefine("BGFX_SHADER_LANGUAGE_GLSL=1"); } - else if (0 == bx::stricmp(platform, "linux") ) + else if (0 == bx::strincmp(platform, "linux") ) { preprocessor.setDefine("BX_PLATFORM_LINUX=1"); if (0 != spirv) @@ -954,12 +954,12 @@ namespace bgfx preprocessor.setDefine(glslDefine); } } - else if (0 == bx::stricmp(platform, "nacl") ) + else if (0 == bx::strincmp(platform, "nacl") ) { preprocessor.setDefine("BX_PLATFORM_NACL=1"); preprocessor.setDefine("BGFX_SHADER_LANGUAGE_GLSL=1"); } - else if (0 == bx::stricmp(platform, "osx") ) + else if (0 == bx::strincmp(platform, "osx") ) { preprocessor.setDefine("BX_PLATFORM_OSX=1"); preprocessor.setDefine(glslDefine); @@ -967,19 +967,19 @@ namespace bgfx bx::snprintf(temp, sizeof(temp), "BGFX_SHADER_LANGUAGE_METAL=%d", metal); preprocessor.setDefine(temp); } - else if (0 == bx::stricmp(platform, "windows") ) + else if (0 == bx::strincmp(platform, "windows") ) { preprocessor.setDefine("BX_PLATFORM_WINDOWS=1"); char temp[256]; bx::snprintf(temp, sizeof(temp), "BGFX_SHADER_LANGUAGE_HLSL=%d", hlsl); preprocessor.setDefine(temp); } - else if (0 == bx::stricmp(platform, "xbox360") ) + else if (0 == bx::strincmp(platform, "xbox360") ) { preprocessor.setDefine("BX_PLATFORM_XBOX360=1"); preprocessor.setDefine("BGFX_SHADER_LANGUAGE_HLSL=3"); } - else if (0 == bx::stricmp(platform, "orbis") ) + else if (0 == bx::strincmp(platform, "orbis") ) { preprocessor.setDefine("BX_PLATFORM_PS4=1"); preprocessor.setDefine("BGFX_SHADER_LANGUAGE_PSSL=1"); diff --git a/tools/texturec/texturec.cpp b/tools/texturec/texturec.cpp index 6c7f2b409..e1c60ca1d 100644 --- a/tools/texturec/texturec.cpp +++ b/tools/texturec/texturec.cpp @@ -59,6 +59,7 @@ BX_PRAGMA_DIAGNOSTIC_POP(); BX_PRAGMA_DIAGNOSTIC_PUSH() BX_PRAGMA_DIAGNOSTIC_IGNORED_CLANG_GCC("-Wtype-limits") +BX_PRAGMA_DIAGNOSTIC_IGNORED_CLANG_GCC("-Wunused-parameter") BX_PRAGMA_DIAGNOSTIC_IGNORED_CLANG_GCC("-Wunused-value") BX_PRAGMA_DIAGNOSTIC_IGNORED_MSVC(4100) // error C4100: '' : unreferenced formal parameter #define MINIZ_NO_STDIO diff --git a/tools/texturev/texturev.cpp b/tools/texturev/texturev.cpp index ed1a1b86e..de60ce6a0 100644 --- a/tools/texturev/texturev.cpp +++ b/tools/texturev/texturev.cpp @@ -319,7 +319,7 @@ struct View bool supported = false; for (uint32_t ii = 0; ii < BX_COUNTOF(s_supportedExt); ++ii) { - if (0 == bx::stricmp(ext, s_supportedExt[ii]) ) + if (0 == bx::strincmp(ext, s_supportedExt[ii]) ) { supported = true; break;